Skip to content

[UR][SYCL] Add support for zeCommandListAppendLaunchKernelWithArguments() #20316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2025
Merged

[UR][SYCL] Add support for zeCommandListAppendLaunchKernelWithArguments() #20316

merged 3 commits into from
Oct 30, 2025

Conversation

@ldorau
Copy link
Contributor

@ldorau ldorau commented Oct 8, 2025

No description provided.

@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from 816fda9 to f2b4eb5 Compare October 9, 2025 21:13
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from f2b4eb5 to a766e0e Compare October 9, 2025 21:14
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from a766e0e to 2e469a3 Compare October 9, 2025 21:31
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch 2 times, most recently from 896f37c to f10396e Compare October 10, 2025 19:43
@ldorau
Copy link
Contributor Author

ldorau commented Oct 10, 2025

Rebased

@ldorau ldorau requested a review from slawekptak October 10, 2025 20:09
@ldorau ldorau mentioned this pull request Oct 11, 2025
Closed
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch 4 times, most recently from d3db808 to 1c86d5c Compare October 15, 2025 09:04
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from 1c86d5c to 8fafee6 Compare October 15, 2025 09:54
@ldorau ldorau changed the title [UR][SYCL] Add support for zeCommandListAppendLaunchKernelWithArguments() [UR][SYCL] Add support for zeCommandListAppendLaunchKernelWithArguments() Oct 15, 2025
@ldorau
Copy link
Contributor Author

ldorau commented Oct 28, 2025

@aelovikov-intel @pbalcer @slawekptak re-review please

aelovikov-intel
aelovikov-intel reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is somewhat messy, but I can't think how it could be improved, so LGTM, except one inline comment.

sycl/test/gdb/printers.cpp Outdated

// CHECK: 0 | class sycl::detail::queue_impl
// CHECK: 56 | device_impl & MDevice
// CHECK: 16 | class sycl::detail::array<> (base)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to this file mean that some other file with gdb printers needs updates. In particular, we need to know the offset from queue_impl to device_impl.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but which other file? What and where should be updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. This change is not needed. I have reverted that.
Done.

@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from 4d5e639 to 1007ca3 Compare October 29, 2025 09:09
kswiecicki
kswiecicki reviewed Oct 29, 2025
View reviewed changes
@ldorau ldorau force-pushed the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch from 1007ca3 to 467faad Compare October 29, 2025 11:22
@ldorau
[UR][SYCL] Add support for zeCommandListAppendLaunchKernelWithArgumen…
467faad 
…ts()

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau
Copy link
Contributor Author

ldorau commented Oct 29, 2025

@intel/dpcpp-nativecpu-reviewers @intel/llvm-reviewers-cuda @intel/llvm-reviewers-runtime @intel/unified-runtime-reviewers-opencl please review

@ldorau
Copy link
Contributor Author

ldorau commented Oct 29, 2025 •
edited
Loading

@steffenlarsen Could you review this PR on behalf of @intel/dpcpp-nativecpu-reviewers ?

steffenlarsen
steffenlarsen approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I was just granted these powers yesterday. NativeCPU changes LGTM!

@github-actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

vinser52
vinser52 reviewed Oct 29, 2025
View reviewed changes
@ldorau
Copy link
Contributor Author

ldorau commented Oct 30, 2025

@intel/llvm-gatekeepers please merge

@ldorau
Copy link
Contributor Author

ldorau commented Oct 30, 2025

Apologies, I was just granted these powers yesterday. NativeCPU changes LGTM!

Thank you! :-)

@kswiecicki kswiecicki merged commit 5df5f45 into intel:sycl Oct 30, 2025
49 of 50 checks passed
@ldorau ldorau deleted the Add_support_for_zeCommandListAppendLaunchKernelWithArguments branch October 30, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinser52 vinser52 vinser52 left review comments

@YuriPlyakhin YuriPlyakhin YuriPlyakhin approved these changes

@pbalcer pbalcer pbalcer approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@kswiecicki kswiecicki kswiecicki approved these changes

@slawekptak slawekptak Awaiting requested review from slawekptak

@bratpiorka bratpiorka Awaiting requested review from bratpiorka bratpiorka is a code owner automatically assigned from intel/llvm-reviewers-cuda

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@ldorau @mmichel11 @YuriPlyakhin @vinser52 @pbalcer @slawekptak @aelovikov-intel @steffenlarsen @kswiecicki